feat(apps-engine): add `customFields` on livechat creation by ggazzo · Pull Request #32328 · RocketChat/Rocket.Chat

ggazzo · 2024-04-29T16:07:11Z

https://rocketchat.atlassian.net/browse/OPI-10

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-566

Steps to test or reproduce

Further comments

dionisio-bot · 2024-04-29T16:07:16Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2024-04-29T16:07:16Z

🦋 Changeset detected

Latest commit: b282076

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-04-29T16:16:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.73%. Comparing base (209a062) to head (c92e338).

❗ Current head c92e338 differs from pull request most recent head b282076

Please upload reports for the commit b282076 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32328      +/-   ##
===========================================
- Coverage    56.76%   56.73%   -0.04%     
===========================================
  Files         2496     2496              
  Lines        55358    55358              
  Branches     11455    11455              
===========================================
- Hits         31423    31405      -18     
- Misses       21241    21254      +13     
- Partials      2694     2699       +5

Flag	Coverage Δ
e2e	`56.47% <ø> (-0.04%)`	⬇️
unit	`71.86% <ø> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman

Ill assume the release of apps engine has the changes from the release that was pushed on 6.8 😬

ricardogarim · 2024-06-25T03:41:48Z

Using same test pipeline as #32620 to wrap up some context regarding this improvement - mainly focused on WhatsApp app.

Use case	Avg Duration (ms)	Min Duration (ms)	Median Duration (ms)	Max Duration (ms)	90th Percentile (ms)	95th Percentile (ms)
New visitor BEFORE	421.47	243.77	397.15	966.75	573.58	771.39
New visitor AFTER	381.36	181.74	359.88	842.36	521.56	576.97
Same visitor BEFORE	180.55	98.36	159.26	571.61	257.87	302.76
Same visitor AFTER	192.53	97.38	179.33	582.9	272.97	337.69

K6 test results before changes

Incoming messages from WhatsApp flow with new visitor on every request.

          /\      |‾‾| /‾‾/   /‾‾/   
     /\  /  \     |  |/  /   /  /    
    /  \/    \    |     (   /   ‾‾\  
   /          \   |  |\  \ |  (‾)  | 
  / __________ \  |__| \__\ \_____/ .io

     execution: local
        script: src/incoming-message.js
        output: -

     scenarios: (100.00%) 1 scenario, 1 max VUs, 10m30s max duration (incl. graceful stop):
              * default: 100 iterations shared among 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)


     data_received..................: 76 kB 1.8 kB/s
     data_sent......................: 47 kB 1.1 kB/s
     http_req_blocked...............: avg=34.36µs  min=2µs      med=3µs      max=3.08ms   p(90)=5µs      p(95)=7.04µs  
     http_req_connecting............: avg=2.52µs   min=0s       med=0s       max=252µs    p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=421.25ms min=243.32ms med=397ms    max=966.56ms p(90)=573.41ms p(95)=771.2ms 
       { expected_response:true }...: avg=421.25ms min=243.32ms med=397ms    max=966.56ms p(90)=573.41ms p(95)=771.2ms 
     http_req_failed................: 0.00% ✓ 0        ✗ 100
     http_req_receiving.............: avg=102.3µs  min=51µs     med=71.5µs   max=2.37ms   p(90)=113.7µs  p(95)=144.24µs
     http_req_sending...............: avg=39.37µs  min=18µs     med=26µs     max=1ms      p(90)=45µs     p(95)=51.69µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=421.11ms min=243.09ms med=396.88ms max=966.45ms p(90)=573.28ms p(95)=771.09ms
     http_reqs......................: 100   2.372477/s
     iteration_duration.............: avg=421.47ms min=243.77ms med=397.15ms max=966.75ms p(90)=573.58ms p(95)=771.39ms
     iterations.....................: 100   2.372477/s
     vus............................: 1     min=1      max=1
     vus_max........................: 1     min=1      max=1


running (00m42.2s), 0/1 VUs, 100 complete and 0 interrupted iterations
default ✓ [======================================] 1 VUs  00m42.2s/10m0s  100/100 shared iters

Incoming messages from WhatsApp flow with same visitor on every request.

          /\      |‾‾| /‾‾/   /‾‾/   
     /\  /  \     |  |/  /   /  /    
    /  \/    \    |     (   /   ‾‾\  
   /          \   |  |\  \ |  (‾)  | 
  / __________ \  |__| \__\ \_____/ .io

     execution: local
        script: src/incoming-message.js
        output: -

     scenarios: (100.00%) 1 scenario, 1 max VUs, 10m30s max duration (incl. graceful stop):
              * default: 100 iterations shared among 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)


     data_received..................: 76 kB 4.2 kB/s
     data_sent......................: 46 kB 2.6 kB/s
     http_req_blocked...............: avg=29.06µs  min=2µs     med=3µs      max=2.55ms   p(90)=5µs      p(95)=5µs     
     http_req_connecting............: avg=3.23µs   min=0s      med=0s       max=323µs    p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=180.32ms min=98.24ms med=159.06ms max=571.45ms p(90)=257.67ms p(95)=302.6ms 
       { expected_response:true }...: avg=180.32ms min=98.24ms med=159.06ms max=571.45ms p(90)=257.67ms p(95)=302.6ms 
     http_req_failed................: 0.00% ✓ 0        ✗ 100
     http_req_receiving.............: avg=88.98µs  min=50µs    med=75.5µs   max=1.09ms   p(90)=99µs     p(95)=130.1µs 
     http_req_sending...............: avg=35.16µs  min=18µs    med=25µs     max=834µs    p(90)=37.1µs   p(95)=44.09µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=180.19ms min=98.16ms med=158.96ms max=571.36ms p(90)=257.57ms p(95)=302.5ms 
     http_reqs......................: 100   5.537726/s
     iteration_duration.............: avg=180.55ms min=98.36ms med=159.26ms max=571.61ms p(90)=257.87ms p(95)=302.76ms
     iterations.....................: 100   5.537726/s
     vus............................: 1     min=1      max=1
     vus_max........................: 1     min=1      max=1


running (00m18.1s), 0/1 VUs, 100 complete and 0 interrupted iterations
default ✓ [======================================] 1 VUs  00m18.1s/10m0s  100/100 shared iters

K6 test results after changes

Incoming messages from WhatsApp flow with new visitor on every request.

          /\      |‾‾| /‾‾/   /‾‾/   
     /\  /  \     |  |/  /   /  /    
    /  \/    \    |     (   /   ‾‾\  
   /          \   |  |\  \ |  (‾)  | 
  / __________ \  |__| \__\ \_____/ .io

     execution: local
        script: src/incoming-message.js
        output: -

     scenarios: (100.00%) 1 scenario, 1 max VUs, 10m30s max duration (incl. graceful stop):
              * default: 100 iterations shared among 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)


     data_received..................: 76 kB 2.0 kB/s
     data_sent......................: 46 kB 1.2 kB/s
     http_req_blocked...............: avg=23.63µs  min=2µs      med=3µs      max=1.99ms   p(90)=5µs      p(95)=8µs     
     http_req_connecting............: avg=1.85µs   min=0s       med=0s       max=185µs    p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=381.1ms  min=178.73ms med=359.66ms max=842.21ms p(90)=521.39ms p(95)=573.72ms
       { expected_response:true }...: avg=381.1ms  min=178.73ms med=359.66ms max=842.21ms p(90)=521.39ms p(95)=573.72ms
     http_req_failed................: 0.00% ✓ 0        ✗ 100
     http_req_receiving.............: avg=78.76µs  min=50µs     med=69.5µs   max=242µs    p(90)=106.4µs  p(95)=130.05µs
     http_req_sending...............: avg=29.39µs  min=18µs     med=24µs     max=177µs    p(90)=36.1µs   p(95)=53.04µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=380.99ms min=178.45ms med=359.57ms max=842.13ms p(90)=521.3ms  p(95)=573.64ms
     http_reqs......................: 100   2.621529/s
     iteration_duration.............: avg=381.36ms min=181.74ms med=359.88ms max=842.36ms p(90)=521.56ms p(95)=576.97ms
     iterations.....................: 100   2.621529/s
     vus............................: 1     min=1      max=1
     vus_max........................: 1     min=1      max=1


running (00m38.1s), 0/1 VUs, 100 complete and 0 interrupted iterations
default ✓ [======================================] 1 VUs  00m38.1s/10m0s  100/100 shared iters

Incoming messages from WhatsApp flow with same visitor on every request.

          /\      |‾‾| /‾‾/   /‾‾/   
     /\  /  \     |  |/  /   /  /    
    /  \/    \    |     (   /   ‾‾\  
   /          \   |  |\  \ |  (‾)  | 
  / __________ \  |__| \__\ \_____/ .io

     execution: local
        script: src/incoming-message.js
        output: -

     scenarios: (100.00%) 1 scenario, 1 max VUs, 10m30s max duration (incl. graceful stop):
              * default: 100 iterations shared among 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)


     data_received..................: 76 kB 3.9 kB/s
     data_sent......................: 46 kB 2.4 kB/s
     http_req_blocked...............: avg=58.22µs  min=2µs     med=3µs      max=5.46ms   p(90)=5.1µs    p(95)=8.04µs  
     http_req_connecting............: avg=7.75µs   min=0s      med=0s       max=775µs    p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=192.18ms min=97.24ms med=179.14ms max=580.35ms p(90)=272.83ms p(95)=337.54ms
       { expected_response:true }...: avg=192.18ms min=97.24ms med=179.14ms max=580.35ms p(90)=272.83ms p(95)=337.54ms
     http_req_failed................: 0.00% ✓ 0        ✗ 100
     http_req_receiving.............: avg=106.17µs min=52µs    med=77.5µs   max=1.65ms   p(90)=131µs    p(95)=215.1µs 
     http_req_sending...............: avg=47.44µs  min=18µs    med=25µs     max=1.44ms   p(90)=40.1µs   p(95)=49.89µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=192.03ms min=97.12ms med=179.02ms max=580.2ms  p(90)=272.63ms p(95)=337.4ms 
     http_reqs......................: 100   5.193125/s
     iteration_duration.............: avg=192.53ms min=97.38ms med=179.33ms max=582.9ms  p(90)=272.97ms p(95)=337.69ms
     iterations.....................: 100   5.193125/s
     vus............................: 1     min=1      max=1
     vus_max........................: 1     min=1      max=1


running (00m19.3s), 0/1 VUs, 100 complete and 0 interrupted iterations
default ✓ [======================================] 1 VUs  00m19.3s/10m0s  100/100 shared iters

ggazzo force-pushed the feat/allow-customfields-by-room-creation branch from 80a5cfa to 1307136 Compare April 29, 2024 16:09

ggazzo force-pushed the feat/allow-customfields-by-room-creation branch from c51616a to a345020 Compare May 9, 2024 18:58

KevLehman previously approved these changes May 10, 2024

View reviewed changes

sampaiodiego added the stat: conflict label Jun 24, 2024

ggazzo dismissed KevLehman’s stale review via f671a22 June 24, 2024 15:15

ggazzo force-pushed the feat/allow-customfields-by-room-creation branch from a345020 to f671a22 Compare June 24, 2024 15:15

dionisio-bot bot removed the stat: conflict label Jun 24, 2024

ricardogarim marked this pull request as ready for review June 25, 2024 12:08

ricardogarim requested a review from a team as a code owner June 25, 2024 12:08

ggazzo requested review from a team as code owners June 25, 2024 14:13

ggazzo added 4 commits June 25, 2024 11:29

allow customfield during livechat room creation

00b8616

..

b7fa7aa

..

500e198

..

73690cb

ggazzo force-pushed the feat/allow-customfields-by-room-creation branch 2 times, most recently from c22b200 to f7baab0 Compare June 25, 2024 15:21

chore: improve omnichannel typings

c92e338

ggazzo force-pushed the feat/allow-customfields-by-room-creation branch from f7baab0 to c92e338 Compare June 25, 2024 16:05

ricardogarim previously approved these changes Jun 25, 2024

View reviewed changes

ggazzo added this to the 6.11 milestone Jun 25, 2024

ggazzo changed the title ~~feat: allow customfield during livechat room creation~~ feat(apps-engine): add customFields on livechat creation Jun 25, 2024

Create rare-penguins-hope.md

b282076

ggazzo dismissed ricardogarim’s stale review via b282076 June 25, 2024 21:09

ggazzo merged commit 24f7df4 into develop Jun 25, 2024

ggazzo deleted the feat/allow-customfields-by-room-creation branch June 25, 2024 21:11

rocketchat-github-ci mentioned this pull request Jul 25, 2024

Release 6.11.0 #32901

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat(apps-engine): add `customFields` on livechat creation#32328

feat(apps-engine): add `customFields` on livechat creation#32328
ggazzo merged 6 commits intodevelopfrom
feat/allow-customfields-by-room-creation

ggazzo commented Apr 29, 2024 •

edited

Loading

Uh oh!

dionisio-bot bot commented Apr 29, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 29, 2024 •

edited

Loading

Uh oh!

codecov bot commented Apr 29, 2024 •

edited

Loading

Uh oh!

KevLehman left a comment

Uh oh!

ricardogarim commented Jun 25, 2024

Incoming messages from WhatsApp flow with new visitor on every request.

Incoming messages from WhatsApp flow with same visitor on every request.

Incoming messages from WhatsApp flow with new visitor on every request.

Incoming messages from WhatsApp flow with same visitor on every request.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

ggazzo commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

KevLehman left a comment

Choose a reason for hiding this comment

Uh oh!

ricardogarim commented Jun 25, 2024

Incoming messages from WhatsApp flow with new visitor on every request.

Incoming messages from WhatsApp flow with same visitor on every request.

Incoming messages from WhatsApp flow with new visitor on every request.

Incoming messages from WhatsApp flow with same visitor on every request.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ggazzo commented Apr 29, 2024 •

edited

Loading

dionisio-bot bot commented Apr 29, 2024 •

edited

Loading

changeset-bot bot commented Apr 29, 2024 •

edited

Loading

codecov bot commented Apr 29, 2024 •

edited

Loading