Skip to content

regression: move conversation closing tags field after the toggle that enables it#32340

Merged
kodiakhq[bot] merged 1 commit intorelease-6.8.0from
reg-core403
Apr 30, 2024
Merged

regression: move conversation closing tags field after the toggle that enables it#32340
kodiakhq[bot] merged 1 commit intorelease-6.8.0from
reg-core403

Conversation

@csuadev
Copy link
Copy Markdown
Contributor

@csuadev csuadev commented Apr 30, 2024

Move the conversation closing tags field just after the toggle that enables it since there was a "Allow department to receive forwarded inquiries" in the middle of both.

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-403

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: a977f3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.45%. Comparing base (4cb5792) to head (a977f3d).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.8.0   #32340      +/-   ##
=================================================
- Coverage          55.46%   55.45%   -0.02%     
=================================================
  Files               2376     2370       -6     
  Lines              52179    52104      -75     
  Branches           10667    10651      -16     
=================================================
- Hits               28941    28894      -47     
+ Misses             20696    20678      -18     
+ Partials            2542     2532      -10     
Flag Coverage Δ
e2e 54.78% <ø> (-0.03%) ⬇️
unit 75.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuadev csuadev marked this pull request as ready for review April 30, 2024 13:46
@csuadev csuadev requested a review from a team as a code owner April 30, 2024 13:46
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Apr 30, 2024
@MartinSchoeler MartinSchoeler added this to the 6.8 milestone Apr 30, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2024
@kodiakhq kodiakhq bot merged commit 3a9fa67 into release-6.8.0 Apr 30, 2024
@kodiakhq kodiakhq bot deleted the reg-core403 branch April 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants