Skip to content

feat: Scrollbar color contrast improvement#32341

Merged
kodiakhq[bot] merged 3 commits intodevelopfrom
feat/scrollbarsColor
May 2, 2024
Merged

feat: Scrollbar color contrast improvement#32341
kodiakhq[bot] merged 3 commits intodevelopfrom
feat/scrollbarsColor

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Apr 30, 2024

Proposed changes (including videos or screenshots)

light theme

dark theme

Issue(s)

Closes #32367

Steps to test or reproduce

Further comments

CORE-309

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: ed4680c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris added this to the 6.9 milestone Apr 30, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.94%. Comparing base (70ab2a7) to head (ed4680c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32341      +/-   ##
===========================================
- Coverage    55.54%   54.94%   -0.60%     
===========================================
  Files         2403     2355      -48     
  Lines        52847    51935     -912     
  Branches     10854    10622     -232     
===========================================
- Hits         29352    28535     -817     
+ Misses       20888    20834      -54     
+ Partials      2607     2566      -41     
Flag Coverage Δ
e2e 53.61% <100.00%> (-1.18%) ⬇️
unit 73.60% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review April 30, 2024 20:29
@dougfabris dougfabris requested a review from a team as a code owner April 30, 2024 20:29
@dougfabris dougfabris force-pushed the feat/scrollbarsColor branch from 2057f3b to 9a9abdc Compare May 2, 2024 18:51
juliajforesti
juliajforesti previously approved these changes May 2, 2024
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label May 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrollbars are impossible to see

2 participants