fix: BurgerMenu wrong semantics and colors #32345
Merged
kodiakhq[bot] merged 9 commits intodevelopfrom May 7, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c96200d The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32345 +/- ##
==========================================
Coverage ? 52.54%
==========================================
Files ? 2160
Lines ? 49277
Branches ? 10101
==========================================
Hits ? 25892
Misses ? 21028
Partials ? 2357
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
force-pushed
the
fix/burgerMenuColor
branch
from
1f3b7fc to
d89bc7d
Compare
tiagoevanp
reviewed
May 3, 2024
tiagoevanp
reviewed
May 3, 2024
Contributor
tiagoevanp
left a comment
tiagoevanp
left a comment
There was a problem hiding this comment.
No tests for burguer menu button (click and behavior)?
yash-rajpal
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
before
after
Issue(s)
Steps to test or reproduce
Further comments
CORE-412