Skip to content

refactor: #32040 review#32365

Merged
yash-rajpal merged 2 commits intoe2e-unencrypted-settingfrom
review
May 7, 2024
Merged

refactor: #32040 review#32365
yash-rajpal merged 2 commits intoe2e-unencrypted-settingfrom
review

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh commented May 2, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner May 2, 2024 20:17
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented May 2, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9885bbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented May 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 53.49%. Comparing base (2053ccf) to head (dc4a118).

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           e2e-unencrypted-setting   #32365      +/-   ##
===========================================================
+ Coverage                    53.44%   53.49%   +0.05%     
===========================================================
  Files                         2270     2270              
  Lines                        50823    50822       -1     
  Branches                     10387    10386       -1     
===========================================================
+ Hits                         27160    27189      +29     
+ Misses                       21213    21184      -29     
+ Partials                      2450     2449       -1
Flag Coverage Δ
e2e 50.74% <33.33%> (+0.07%) ⬆️
unit 73.57% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

yash-rajpal
yash-rajpal approved these changes May 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yash-rajpal yash-rajpal merged commit 9ec6345 into e2e-unencrypted-setting May 7, 2024
@yash-rajpal yash-rajpal deleted the review branch May 7, 2024 15:30
MarcosSpessatto pushed a commit that referenced this pull request May 28, 2024
@yash-rajpal @scuciatto
@gabriellsh @hugocostadev
feat: E2e room setup header2 (#32515)
4a6bf88 
* add new e2ee setting

* add e2ee hooks

* Warning UI

* integrating everything

* add translations

* small refactor

* don't allow un-encrypted messages on server side

* introduce e2ee states

* fix TS and fix lint

* refactor and remove unused code

* needle in haystack

* remove memoizing

* room with e2ee setup routing

* remove useIsE2EEReady hook

* update docs link to go.rocket.chat url

* avoid attaching listners multiple times

* add e2e tests

* review (#32365)

Co-authored-by: yash-rajpal <rajpal.yash03@gmail.com>

* fix review

* fix: removing commments, replacing deprecated type method with fill and restoring commented test

* e2e tests reuse channel creation

* comment floky test

* add cs

* release the instance on changing the room encrypted property

* oops: TS

* fix flaky test

* setting description

* wip: e2e setup room header

* default setting value

* add cs

* api test cases

* e2e tests setting value

* more api tests

* oops

* toast messages

* refactor

* hmm

* tests

* fix tests

* handle E2EE disabled case

* handle wrong password case

* fix tests

---------

Co-authored-by: yash-rajpal <rajpal.yash03@gmail.com>
Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
Co-authored-by: Felipe Scuciatto <scuciatto@gmail.com>
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yash-rajpal yash-rajpal yash-rajpal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabriellsh @yash-rajpal