regression: Thread file upload

[yash-rajpal]

Proposed changes (including videos or screenshots)

When the user uploads an image to a thread, it gets sent to the channel instead.

Issue(s)

Introduced here: #32324

Steps to test or reproduce

1. Open a channel
2. Send a message
3. Hover the message → Start a thread
4. Send a message inside the thread
5. Inside the thread, send an image

Further comments

CORE-421

[changeset-bot]

⚠️ No Changeset found

Latest commit: b568c01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.41%. Comparing base (048a977) to head (b568c01).

Additional details and impacted files

@@                Coverage Diff                @@
##           release-6.8.0   #32368      +/-   ##
=================================================
- Coverage          55.41%   55.41%   -0.01%     
=================================================
  Files               2370     2374       +4     
  Lines              52094    52143      +49     
  Branches           10653    10660       +7     
=================================================
+ Hits               28868    28895      +27     
+ Misses             20707    20697      -10     
- Partials            2519     2551      +32     

Flag	Coverage Δ
e2e	54.71% <ø> (+<0.01%)	⬆️
unit	75.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

I know what Marcos will ask

[debdutdeb]

possible we get tests written for this?

[sampaiodiego]

do you know what caused this regression? just so we can take a look for other possible regressions as well

[yash-rajpal]

@sampaiodiego This regression was caused by #32324 - when we reverted the encryption of file description. We missed reverting this one line.

I don't think their are anymore regressions related to this.

[sampaiodiego]

thx @yash-rajpal .. I'm bit confused though.. because this code used to add the whole msgData not just the tmid field, like:

const msg = await executeSendMessage(userId, {
   // ...
   ...(msgData as Partial<IMessage>),
   // ...
});

why not make it like it was before?

[sampaiodiego]

We missed reverting this one line.

do you mean you didn't use git revert to revert the other PR? that's scary 🙈

[yash-rajpal]

I used git revert but there was a conflict in this file and missed that part 😞

[dougfabris]

LGTM!