fix: Modals opened by apps won't close when executeViewCloseHandler is not implemented#32374
Merged
kodiakhq[bot] merged 3 commits intorelease-6.8.0from May 7, 2024
Merged
fix: Modals opened by apps won't close when executeViewCloseHandler is not implemented#32374kodiakhq[bot] merged 3 commits intorelease-6.8.0from
executeViewCloseHandler is not implemented#32374kodiakhq[bot] merged 3 commits intorelease-6.8.0from
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 9964572 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.8.0 #32374 +/- ##
=================================================
- Coverage 55.41% 54.32% -1.09%
=================================================
Files 2370 2294 -76
Lines 52094 50991 -1103
Branches 10653 10442 -211
=================================================
- Hits 28868 27701 -1167
- Misses 20707 20832 +125
+ Partials 2519 2458 -61
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
requested changes
May 7, 2024
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
What does this bump do? It seems to me that it's a fix, could you add a changeset explaining what it fixes? otherwise people won't know what was fixed
AllanPazRibeiro
previously approved these changes
May 7, 2024
KevLehman
changed the title
@rocket.chat/apps-engine versionexecuteViewCloseHandler is not implemented
ggazzo
approved these changes
May 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocketchat.atlassian.net/browse/CORE-401
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Fixes an issue with some apps that didn't implement executeViewCloseHandler. This causes opened modals to be open forever on UI. This is because when the UI attempts to close it, it calls the aforementioned handler, and since it didn't exist, apps engine errored out.
This returned an empty response to the UI, which ignored the response and continued to show the view.