Skip to content

ci: add UI tests with DB watchers disabled#32397

Merged
kodiakhq[bot] merged 3 commits intodevelopfrom
ci-add-no-watcher-flag
May 10, 2024
Merged

ci: add UI tests with DB watchers disabled#32397
kodiakhq[bot] merged 3 commits intodevelopfrom
ci-add-no-watcher-flag

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego commented May 9, 2024

Proposed changes (including videos or screenshots)

We're slowly moving towards making DISABLE_DB_WATCHERS=true the default behavior, so the intent of this PR is to have tests running using the setting enabled so we can make sure we're covering all test cases while we migrate the code.

Issue(s)

#32403 needs to be merged first so the tests can pass.

SCA-4

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented May 9, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: 40050b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (a3ef33c) to head (40050b6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32397      +/-   ##
===========================================
+ Coverage    54.42%   55.57%   +1.15%     
===========================================
  Files         2385     2401      +16     
  Lines        52294    52880     +586     
  Branches     10719    10865     +146     
===========================================
+ Hits         28461    29390     +929     
+ Misses       21290    20891     -399     
- Partials      2543     2599      +56     
Flag Coverage Δ
e2e 54.92% <ø> (+2.15%) ⬆️
unit 73.32% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego force-pushed the ci-add-no-watcher-flag branch 2 times, most recently from 318db44 to f49af2b Compare May 10, 2024 00:36
@sampaiodiego sampaiodiego marked this pull request as ready for review May 10, 2024 01:10
@sampaiodiego sampaiodiego requested review from a team as code owners May 10, 2024 01:10
@sampaiodiego sampaiodiego added this to the 6.9 milestone May 10, 2024
@sampaiodiego sampaiodiego force-pushed the ci-add-no-watcher-flag branch from f49af2b to bd3c66c Compare May 10, 2024 03:44
@sampaiodiego sampaiodiego removed the request for review from a team May 10, 2024 03:57
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label May 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 10, 2024
@kodiakhq kodiakhq bot merged commit 3433f48 into develop May 10, 2024
@kodiakhq kodiakhq bot deleted the ci-add-no-watcher-flag branch May 10, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants