Skip to content

Comments

feat: VoIP backend for FreeSwitch#32435

Closed
pierre-lehnen-rc wants to merge 5 commits intofeat/voip-freeswitch-feature-branchfrom
feat/voip-freeswitch
Closed

feat: VoIP backend for FreeSwitch#32435
pierre-lehnen-rc wants to merge 5 commits intofeat/voip-freeswitch-feature-branchfrom
feat/voip-freeswitch

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented May 14, 2024

Proposed changes (including videos or screenshots)

This PR adds a new page on the admin settings where an admin can configure and enable access to a FreeSwitch instance.

It also adds a new option to the list of users in the admin control panel. This new option allows admins to assign free switch users (extensions) to the rocket.chat users, so that they may use the VoIP capability in TeamCollab.

Finally it also adds all the endpoints the webclient may need in order to get the required information to connect a rocket.chat user to VoIP calls.

Issue(s)

VOIP-19
VOIP-20
VOIP-21
VOIP-26
VOIP-32
VOIP-34
VOIP-35
VOIP-38
VOIP-75
VOIP-76
VOIP-77

Steps to test or reproduce

Further comments

New endpoints:

voip-freeswitch.extension.list
voip-freeswitch.extension.getDetails
voip-freeswitch.extension.assign
voip-freeswitch.extension.getRegistrationInfoByUserId

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 14, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 001d4ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 12.12121% with 87 lines in your changes missing coverage. Please review.

Project coverage is 54.80%. Comparing base (1e42acc) to head (e282455).

Current head e282455 differs from pull request most recent head 9950914

Please upload reports for the commit 9950914 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##           feat/voip-freeswitch-feature-branch   #32435      +/-   ##
=======================================================================
- Coverage                                54.88%   54.80%   -0.09%     
=======================================================================
  Files                                     2384     2387       +3     
  Lines                                    52601    52702     +101     
  Branches                                 10828    10853      +25     
=======================================================================
+ Hits                                     28872    28885      +13     
- Misses                                   21156    21243      +87     
- Partials                                  2573     2574       +1     
Flag Coverage Δ
e2e 53.79% <ø> (+<0.01%) ⬆️
unit 72.31% <12.12%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review May 21, 2024 20:06
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners May 21, 2024 20:06
@pierre-lehnen-rc pierre-lehnen-rc changed the base branch from meteor-3.0.0 to feat/voip-freeswitch-feature-branch May 23, 2024 17:52
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner July 1, 2024 20:23
@pierre-lehnen-rc
Copy link
Contributor Author

Closed in favor of #33093 (moving this feature to the 6.13 release instead of 7.0)

@tassoevan tassoevan deleted the feat/voip-freeswitch branch July 30, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants