refactor(client): Use subcomponents for InfoPanel and UserInfo#32470
refactor(client): Use subcomponents for InfoPanel and UserInfo#32470
InfoPanel and UserInfo#32470Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32470 +/- ##
===========================================
+ Coverage 56.82% 56.89% +0.06%
===========================================
Files 2497 2498 +1
Lines 55304 55345 +41
Branches 11405 11415 +10
===========================================
+ Hits 31428 31490 +62
+ Misses 21170 21152 -18
+ Partials 2706 2703 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Do you mind changing this notation to all places that uses InfoPanel subcomponents, so we can remove the exported object from apps/meteor/client/components/InfoPanel/index.ts
also prefer using import { subComponents } from '../InfoPanel/'
Btw, why so many commits?
Sure, will do. About the commits I am not entirely sure, this branch was checked out of the feat/new-user-panel-pending branch that was recently merged and when it happened git automatically rebased this branch to the develop and duplicated a lot of the commits that were merged in the other branch. I assumed that since the git diff is correct it wouldn't be a problem, but if there's anyway to remove those commits I'd like do know, I'll do a little research on this as well. |
There is some odd thing going on with the commits that should be addressed first.
67fdada to
0ca116c
Compare
0ca116c to
4de9d31
Compare
InfoPanel subcomponents in UserInfo
32a338a to
4587152
Compare
…notation to subcomponents
For Future Reference: The problem Doug mentioned was caused by squash merging the feat/new-user-panel-pending branch. When a branch is squash merged, all the commits in the pull request (PR) are combined into a single commit on the base branch. Because of this, Git loses the ability to track the individual commits from the original branch. If a child branch was created from the |
80655f4
Proposed changes (including videos or screenshots)
Refactored all places that use
InfoPanelandUserInfocomponents as objects and implemented subcomponents and barrel exports/imports for both of them.Jira task: CONN-268
Issue(s)
Steps to test or reproduce
Further comments