fix: Blocked login when dismissed 2FA modal#32482
Merged
kodiakhq[bot] merged 12 commits intodevelopfrom Jul 19, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: c3e0ca9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32482 +/- ##
===========================================
- Coverage 55.59% 55.58% -0.02%
===========================================
Files 2634 2634
Lines 57252 57273 +21
Branches 11857 11860 +3
===========================================
+ Hits 31832 31837 +5
- Misses 22729 22750 +21
+ Partials 2691 2686 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
May 24, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
I know the steps to reproduce the issue are complex, but would it be possible to add some UI tests to ensure the behavior? Executing exactly the steps you attached in the GIF, enabling 2FA, typing user name and pass, pressing ESC, and checking if the login button is enabled?
tassoevan
force-pushed
the
fix/escape-modal-trigger-action
branch
from
8c3bdfd to
9e919b3
Compare
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
tassoevan
force-pushed
the
fix/escape-modal-trigger-action
branch
from
4df72a9 to
bce65a7
Compare
MarcosSpessatto
previously approved these changes
Jul 5, 2024
tassoevan
previously approved these changes
Jul 8, 2024
tiagoevanp
dismissed stale reviews from tassoevan and MarcosSpessatto
via
ee058dd
tassoevan
approved these changes
Jul 17, 2024
tiagoevanp
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fix infinite loading button in login page when 2FA dismissed.
PR introduces the possibility of a function trigger to Modal dismiss (outside click and escape key).
Before:
After:
Issue(s)
Steps to test or reproduce
Further comments
CORE-202