Skip to content

test: fix last dependent cases#32524

Merged
kodiakhq[bot] merged 13 commits intodevelopfrom
test/fix-last-dependent-cases
Jul 8, 2024
Merged

test: fix last dependent cases#32524
kodiakhq[bot] merged 13 commits intodevelopfrom
test/fix-last-dependent-cases

Conversation

@MarcosSpessatto
Copy link
Copy Markdown
Contributor

@MarcosSpessatto MarcosSpessatto commented May 29, 2024

https://rocketchat.atlassian.net/browse/CORE-475

This PR makes the final adjustments for the API tests (except Livechat ones) support running independently

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented May 29, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: bf89108

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (996933b) to head (bf89108).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32524      +/-   ##
===========================================
- Coverage    56.72%   56.72%   -0.01%     
===========================================
  Files         2498     2498              
  Lines        55392    55392              
  Branches     11455    11455              
===========================================
- Hits         31421    31420       -1     
- Misses       21263    21266       +3     
+ Partials      2708     2706       -2     
Flag Coverage Δ
e2e 56.49% <ø> (+<0.01%) ⬆️
unit 71.88% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review June 3, 2024 16:21
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner June 3, 2024 16:21
@MarcosSpessatto MarcosSpessatto marked this pull request as draft June 27, 2024 13:20
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review June 27, 2024 18:01
@MarcosSpessatto MarcosSpessatto added this to the 6.11 milestone Jun 27, 2024
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Jun 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 27, 2024
@kodiakhq kodiakhq bot merged commit 4bafb6a into develop Jul 8, 2024
@kodiakhq kodiakhq bot deleted the test/fix-last-dependent-cases branch July 8, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants