fix: Accounts_LoginExpiration being used differently on codebase#32527
Merged
kodiakhq[bot] merged 19 commits intodevelopfrom Jul 16, 2024
Merged
fix: Accounts_LoginExpiration being used differently on codebase#32527kodiakhq[bot] merged 19 commits intodevelopfrom
Accounts_LoginExpiration being used differently on codebase#32527kodiakhq[bot] merged 19 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 39affda The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32527 +/- ##
===========================================
- Coverage 55.51% 55.49% -0.02%
===========================================
Files 2632 2632
Lines 57174 57174
Branches 11841 11841
===========================================
- Hits 31740 31730 -10
- Misses 22746 22762 +16
+ Partials 2688 2682 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
debdutdeb
reviewed
Jun 3, 2024
MarcosSpessatto
suggested changes
Jun 3, 2024
MarcosSpessatto
suggested changes
Jun 6, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
MarcosSpessatto
suggested changes
Jun 6, 2024
MarcosSpessatto
approved these changes
Jun 10, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
KevLehman
added
the
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-574
Steps to test or reproduce
Further comments
Fixed an inconsistent evaluation of the
Accounts_LoginExpirationsetting over the codebase. In some places, it was being used as milliseconds while in others as days. Invalid values produced different results. A helper function was created to centralize the setting validation and the proper value being returned to avoid edge cases.Negative values may be saved on the settings UI panel but the code will interpret any negative, NaN or 0 value to the default expiration which is 90 days.