Skip to content

regression: Hide prune section based on permission#32531

Merged
kodiakhq[bot] merged 2 commits intorelease-6.9.0from
reg/edit-retention-permission
May 31, 2024
Merged

regression: Hide prune section based on permission#32531
kodiakhq[bot] merged 2 commits intorelease-6.9.0from
reg/edit-retention-permission

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented May 31, 2024

Proposed changes (including videos or screenshots)

Showing the retention policy section on edit room panel for users without permission are throwing error not allowing users editing room at all

Issue(s)

Steps to test or reproduce

Further comments

CORE-478

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented May 31, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: 889621e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 6.9 milestone May 31, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (c54ede3) to head (889621e).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-6.9.0   #32531   +/-   ##
==============================================
  Coverage          56.01%   56.01%           
==============================================
  Files               2431     2431           
  Lines              53556    53555    -1     
  Branches           11029    11028    -1     
==============================================
  Hits               29998    29998           
+ Misses             20929    20928    -1     
  Partials            2629     2629           
Flag Coverage Δ
e2e 55.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review May 31, 2024 17:52
@dougfabris dougfabris requested a review from a team as a code owner May 31, 2024 17:52
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 31, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 31, 2024
@kodiakhq kodiakhq bot merged commit 70dbbd1 into release-6.9.0 May 31, 2024
@kodiakhq kodiakhq bot deleted the reg/edit-retention-permission branch May 31, 2024 19:35
gabriellsh added a commit that referenced this pull request Jun 3, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Release 6.9.0
  Release 6.9.0-rc.2
  fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500)
  fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500)
  regression: Hide prune section based on permission (#32531)
  fix: Users in role table not rendering the empty state properly (#32412)
  refactor: EmailInbox out of DB Watcher (#32501)
  ci: increase issue allowed stale time (#32523)
  regression: Remove impossible sorting from users table "registration status" column (#32506)
  feat: Add contentDisposition option to file storages (#31974)
  i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-05-28Z (#32508)
  Release 6.9.0-rc.1
  fix: Re-login same browser tab issues (#32479)
  regression: Replace read receipt single icon (#32486)
  regression: Incorrect retention policy banner's display rule for teams (#32483)
  chore: Publish npm packages again (#32463)
  ci: publish missing Omnichannel services to DockerHub (#32462)
  Release 6.9.0-rc.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants