fix: Installed apps not appearing in the list if they're not published in the Marketplace#32534
Merged
kodiakhq[bot] merged 7 commits intodevelopfrom Jun 6, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f592533 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32534 +/- ##
===========================================
- Coverage 56.37% 56.37% -0.01%
===========================================
Files 2435 2437 +2
Lines 53728 53770 +42
Branches 11068 11082 +14
===========================================
+ Hits 30289 30311 +22
- Misses 20796 20812 +16
- Partials 2643 2647 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
force-pushed
the
fix/installed-apps-unpublished
branch
from
47e1a7f to
746d9a6
Compare
Gustrb
reviewed
Jun 3, 2024
Gustrb
reviewed
Jun 3, 2024
apps/meteor/client/providers/AppsProvider/storeQueryFunction.ts
Outdated
Show resolved
Hide resolved
Gustrb
reviewed
Jun 3, 2024
rique223
approved these changes
Jun 4, 2024
d-gubert
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
In the internal apps provider, add non-private apps that are installed in the instance to the
installedapp list.Issue(s)
CONN-220
Steps to test or reproduce
NOTE: To test this, you will need access to the workspace's database
installationSourcetomarketplacedb.getCollection("rocketchat_apps").updateOne({ id: "YOUR APP ID" }, { $set: { installationSource: "marketplace" } })This simulates the situation of an app unpublished from the Marketplace, as the record of the app will be present in the instance but not in the return from the Marketplace API
Further comments
Seeing this in the real world is relatively complicated without database access. The real world scenario that would cause this bug is a workspace installing an app from the Marketplace and later on this app being de-listed/unpublished from the Marketplace.