feat: Disable slash commands for encrypted rooms

[yash-rajpal]

Proposed changes (including videos or screenshots)

Currently, several apps and bots don’t work properly in E2EE rooms
So, it is needed to make clear to users that it is not possible to use apps and slash commands if E2EE is enabled in the room.

Issue(s)

Steps to test or reproduce

Further comments

E2EE-24

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 220a40c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages

Name	Type
@rocket.chat/i18n	Patch
@rocket.chat/meteor	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.13%. Comparing base (c5edd04) to head (220a40c).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32548      +/-   ##
===========================================
+ Coverage    55.02%   55.13%   +0.10%     
===========================================
  Files         2390     2394       +4     
  Lines        53126    53186      +60     
  Branches     10933    10945      +12     
===========================================
+ Hits         29234    29322      +88     
+ Misses       21312    21271      -41     
- Partials      2580     2593      +13     

Flag	Coverage Δ
e2e	53.48% <87.50%> (+0.19%)	⬆️
unit	72.15% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[geekgonecrazy]

Slash commands are executed client side aren't they? Won't some still work just the output not encrypted?

[yash-rajpal]

You are right @geekgonecrazy but in latest versions we introduced a new setting and behavior that un-encrypted messages won't be allowed in encrypted rooms.

Also, currently we have no way of knowing which apps and slash-commands won't work with encrypted messages and channels, so we decided to block all apps and slashcommands.

[hugocostadev]

I also think that we need to revisit this, maybe encrypt messages sent by apps/bots if the settings that allow unencrypted messages is enabled

[hugocostadev]

Allow bots and apps if the "Unencrypted messages in encrypted rooms" is enabled

[yash-rajpal]

I also think that we need to revisit this, maybe encrypt messages sent by apps/bots if the settings that allow unencrypted messages is enabled

I don't think that is something possible with current architecture.

[hugocostadev]

LGTM, but it's missing tests too 🫣

[hugocostadev]

Slash commands are not working in not encrypted channels/DMs