fix: Using the banner _id field as a fallback for the view.viewId field

[Gustrb]

Proposed changes (including videos or screenshots)

We were having issues with the seats taken banner, which would've been un-dismissable because it was expecting it to have a view.viewId field.
But since the banner was created before we had this, it was always empty.
This banner was removed in #31047
And it got into the 6.5.0 release onwards, so whenever someone hadn't dismissed the seatsTaken banner and upgraded their workspace, it would now be un-dismissable and would show a toast with the error 'invalid banner'

Issue(s)

Steps to test or reproduce

1. Create a workspace at 6.4.9
2. Go into the License.getMaxActiveUsers and change it to return some fixed amount (this will be easier to test)
3. Add the number of users that would correspond to 80% of that ammount
4. Restart the workspace (now there should be a seats taken banner)
5. Change the workspace version to 6.5.0 (or newer)
6. Close the seats taken banner

(I've had a few issues trying to run this test, my MongoDB would fail to start properly on 6.4.9. To solve this issue, I've deleted the contents of .meteor/local, which did the trick for me :) )

This should actually close the banner and add it to the dismissed banners collection inside MongoDB

Further comments

I could've just added a new migration that would put the value of _id inside the view.viewId field, but since we already have adaptations to have legacy banners I don't think we should add a new migration just for this :P

JIRA Task: https://rocketchat.atlassian.net/browse/SUP-437

[changeset-bot]

🦋 Changeset detected

Latest commit: be9efc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.37%. Comparing base (96e66c8) to head (be9efc2).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32552      +/-   ##
===========================================
- Coverage    56.41%   56.37%   -0.05%     
===========================================
  Files         2437     2437              
  Lines        53773    53815      +42     
  Branches     11082    11097      +15     
===========================================
+ Hits         30335    30336       +1     
- Misses       20792    20836      +44     
+ Partials      2646     2643       -3     

Flag	Coverage Δ
e2e	56.09% <ø> (-0.06%)	⬇️
unit	71.87% <100.00%> (-0.28%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.