feat: Disable some message menu items for encrypted messages.#32559
Merged
kodiakhq[bot] merged 13 commits intodevelopfrom Jun 19, 2024
Merged
feat: Disable some message menu items for encrypted messages.#32559kodiakhq[bot] merged 13 commits intodevelopfrom
kodiakhq[bot] merged 13 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 165e52c The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32559 +/- ##
===========================================
- Coverage 56.55% 56.52% -0.03%
===========================================
Files 2484 2484
Lines 54742 54677 -65
Branches 11302 11285 -17
===========================================
- Hits 30958 30905 -53
+ Misses 21133 21123 -10
+ Partials 2651 2649 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
changed the title
hugocostadev
suggested changes
Jun 10, 2024
Contributor
hugocostadev
left a comment
hugocostadev
left a comment
There was a problem hiding this comment.
Missing tests 🫣
You can create just one test to check disabled items
hugocostadev
suggested changes
Jun 10, 2024
hugocostadev
previously approved these changes
Jun 17, 2024
hugocostadev
previously approved these changes
Jun 19, 2024
milton-rucks
added
the
stat: QA assured
yash-rajpal
added
the
stat: ready to merge
hugocostadev
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently, it is not possible to properly share the content of encrypted messages outside the room.The forwarded message, message link, or quote appears in the destination room as a hash.
So, it is needed to make clear to users that it is not possible to share encrypted messages content.
Issue(s)
Steps to test or reproduce
Further comments
E2EE2-25