fix(Marketplace): Wrong modal if app already purchased#32563
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f8d5fbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32563 +/- ##
========================================
Coverage 56.51% 56.51%
========================================
Files 2484 2484
Lines 54777 54777
Branches 11318 11318
========================================
+ Hits 30957 30958 +1
+ Misses 21172 21170 -2
- Partials 2648 2649 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
csuadev
reviewed
Jun 6, 2024
Contributor
csuadev
left a comment
csuadev
left a comment
There was a problem hiding this comment.
Can we add an e2e test to confirm the flow is correct?
csuadev
approved these changes
Jun 11, 2024
Contributor
csuadev
left a comment
csuadev
left a comment
There was a problem hiding this comment.
Since currently there's no way to test the UI on the marketplace without register the server we leave the tests for the foreseeable future.
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issue that caused a purchase modal to appear even if the app was already acquired in some cases.
CORE-427