fix: Login services button colors

[yash-rajpal]

Proposed changes (including videos or screenshots)

The login services button was not implementing the button color properties, so fixed it and now the login services button will render the button colors as per the settings.

Issue(s)

Steps to test or reproduce

Further comments

SUP-590

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: bb30b5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/web-ui-registration	Major
@rocket.chat/meteor	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.19%. Comparing base (72b8b5e) to head (bb30b5f).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32570      +/-   ##
===========================================
- Coverage    56.85%   56.19%   -0.67%     
===========================================
  Files         2498     2470      -28     
  Lines        55346    54900     -446     
  Branches     11416    11328      -88     
===========================================
- Hits         31466    30850     -616     
- Misses       21166    21381     +215     
+ Partials      2714     2669      -45     

Flag	Coverage Δ
e2e	55.07% <ø> (-1.42%)	⬇️
unit	72.57% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

Would it be possible to add a UI test to ensure the behavior?

[MarcosSpessatto]

I didn't see any test assertion related to the fix, am I missing something? 🤔

[yash-rajpal]

Tested the change of button text setting in existing tests.

[MarcosSpessatto]

Tested the change of button text setting in existing tests.

But what about the issue? Isn't it about the color? 🤔 Didn't see anything mentioning the label..

[dougfabris]

During the login refactor it was a design decision to not allow such customization.

Waiting for their reply to move forward!

[dougfabris]

LGTM!