Skip to content

fix(Omnichannel): nonstop sound on current chats using continuous notifications#32572

Merged
kodiakhq[bot] merged 4 commits intodevelopfrom
nonstop-sound
Jun 11, 2024
Merged

fix(Omnichannel): nonstop sound on current chats using continuous notifications#32572
kodiakhq[bot] merged 4 commits intodevelopfrom
nonstop-sound

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Jun 7, 2024

Issue: SUP-594

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 7, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 26550bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.34%. Comparing base (209ea9f) to head (26550bd).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32572      +/-   ##
===========================================
+ Coverage    56.31%   56.34%   +0.02%     
===========================================
  Files         2438     2438              
  Lines        53846    53847       +1     
  Branches     11103    11104       +1     
===========================================
+ Hits         30324    30340      +16     
+ Misses       20870    20855      -15     
  Partials      2652     2652              
Flag Coverage Δ
e2e 56.06% <100.00%> (+0.04%) ⬆️
unit 71.80% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 7, 2024 18:56
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner June 7, 2024 18:56
@scuciatto scuciatto added this to the 6.10 milestone Jun 7, 2024
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jun 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 11, 2024
@kodiakhq kodiakhq bot merged commit 108ec7f into develop Jun 11, 2024
@kodiakhq kodiakhq bot deleted the nonstop-sound branch June 11, 2024 18:05
@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Jun 11, 2024

/patch

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 11, 2024

Pull request #32588 added to Project: "Patch 6.9.1"

This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants