fix: Inconsistent Markdown Formatting in Custom Status Field#32574
Merged
ggazzo merged 31 commits intoRocketChat:developfrom Aug 21, 2024
Merged
fix: Inconsistent Markdown Formatting in Custom Status Field#32574ggazzo merged 31 commits intoRocketChat:developfrom
ggazzo merged 31 commits intoRocketChat:developfrom
Conversation
🦋 Changeset detectedLatest commit: 5814d01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32574 +/- ##
========================================
Coverage 59.40% 59.40%
========================================
Files 2543 2543
Lines 63183 63179 -4
Branches 14220 14219 -1
========================================
- Hits 37533 37532 -1
+ Misses 22934 22931 -3
Partials 2716 2716 |
Contributor
|
Hey, thanks for your contribution, I was testing it and it fixes the issue with bold and one italic but not the other one, these text test test test |
Contributor
Author
Screen.Recording.-.Jun.11.2024.1.mp4@csuadev I have test the updated code with the specified markdown inputs to ensure all cases are handled correctly. |
csuadev
added
stat: QA tested
stat: QA assured
MarcosSpessatto
suggested changes
Jun 12, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we add tests to ensure the behavior? cc @csuadev
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Contributor
|
I opened a PR with some tests for the component to ensure it renders the html elements as expected: #32914 |
csuadev
approved these changes
Jul 29, 2024
MarcosSpessatto
approved these changes
Aug 15, 2024
Contributor
|
Looks like this PR is ready to merge! 🎉 |
dionisio-bot
bot
added
stat: ready to merge
KevLehman
added
stat: ready to merge
csuadev
added
stat: QA assured
KevLehman
added
stat: ready to merge
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/SUP-537
Proposed changes (including videos or screenshots)
Screen.Recording.-.Jun.8.2024.mp4
Issue(s)
Closes #32544
Closes #32081
Steps to test or reproduce
Further comments
For now, I have successfully tested this with input containing * (asterisk) and _ (underscore) signs. It would be better if I could have more test cases.