Skip to content

regression: Fixed image gallery not working on Electron app#32578

Merged
kodiakhq[bot] merged 3 commits intodevelopfrom
regression/reverse-array-image-gallery
Jun 10, 2024
Merged

regression: Fixed image gallery not working on Electron app#32578
kodiakhq[bot] merged 3 commits intodevelopfrom
regression/reverse-array-image-gallery

Conversation

@matheusbsilva137
Copy link
Copy Markdown
Contributor

@matheusbsilva137 matheusbsilva137 commented Jun 10, 2024

Proposed changes (including videos or screenshots)

  • Fixed image gallery not working on Electron app due to the use of the toReversed js function (not supported in older "browers" such as in the Electron app)
  • Decrease image gallery transition effect duration on pagination

Issue(s)

CORE-490

Steps to test or reproduce

Further comments

Introduced by #32106

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 10, 2024

⚠️ No Changeset found

Latest commit: b89fcd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.41%. Comparing base (c8069f7) to head (b89fcd9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32578      +/-   ##
===========================================
+ Coverage    56.37%   56.41%   +0.04%     
===========================================
  Files         2437     2436       -1     
  Lines        53773    53742      -31     
  Branches     11082    11076       -6     
===========================================
+ Hits         30313    30318       +5     
+ Misses       20810    20776      -34     
+ Partials      2650     2648       -2     
Flag Coverage Δ
e2e 56.14% <ø> (+0.05%) ⬆️
unit 72.15% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review June 10, 2024 16:06
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner June 10, 2024 16:06
@matheusbsilva137
Copy link
Copy Markdown
Contributor Author

Since this issue can only be reproduced in older chromium versions, there's no way to add new end-to-end tests specifically for this (we'd need to downgrade playwright in order to do that).

@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Jun 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 10, 2024
@kodiakhq kodiakhq bot merged commit 96e66c8 into develop Jun 10, 2024
@kodiakhq kodiakhq bot deleted the regression/reverse-array-image-gallery branch June 10, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants