Skip to content

fix: Emoji picker's object and symbols category icon swapped#32612

Merged
ggazzo merged 2 commits intodevelopfrom
fix/emojipicker-icon-swapped
Jun 20, 2024
Merged

fix: Emoji picker's object and symbols category icon swapped#32612
ggazzo merged 2 commits intodevelopfrom
fix/emojipicker-icon-swapped

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Jun 14, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-510

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 467c5c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.40%. Comparing base (d3ab416) to head (467c5c6).
Report is 24 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32612      +/-   ##
===========================================
- Coverage    56.46%   56.40%   -0.06%     
===========================================
  Files         2455     2474      +19     
  Lines        54100    54522     +422     
  Branches     11149    11259     +110     
===========================================
+ Hits         30546    30753     +207     
- Misses       20899    21100     +201     
- Partials      2655     2669      +14     
Flag Coverage Δ
e2e 56.09% <100.00%> (-0.10%) ⬇️
unit 71.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.10 milestone Jun 14, 2024
@dougfabris dougfabris marked this pull request as ready for review June 17, 2024 18:19
@dougfabris dougfabris requested a review from a team as a code owner June 17, 2024 18:19
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jun 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2024
@ggazzo ggazzo merged commit e6bfb4e into develop Jun 20, 2024
@ggazzo ggazzo deleted the fix/emojipicker-icon-swapped branch June 20, 2024 19:44
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants