Skip to content

fix: Not possible to edit room without proper permission with retention policy enabled#32622

Merged
kodiakhq[bot] merged 1 commit intorelease-6.9.2from
backport-6.9.2-32547
Jun 18, 2024
Merged

fix: Not possible to edit room without proper permission with retention policy enabled#32622
kodiakhq[bot] merged 1 commit intorelease-6.9.2from
backport-6.9.2-32547

Conversation

@dionisio-bot
Copy link
Copy Markdown
Contributor

@dionisio-bot dionisio-bot bot commented Jun 18, 2024

Backport of #32547

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner June 18, 2024 14:35
@dionisio-bot dionisio-bot bot requested a review from dougfabris June 18, 2024 14:35
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 9db96dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.9 milestone Jun 18, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor Author

dionisio-bot bot commented Jun 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.98%. Comparing base (ce72824) to head (9db96dd).
Report is 1 commits behind head on release-6.9.2.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.9.2   #32622      +/-   ##
=================================================
- Coverage          55.99%   55.98%   -0.01%     
=================================================
  Files               2431     2431              
  Lines              53553    53559       +6     
  Branches           11027    11029       +2     
=================================================
  Hits               29987    29987              
+ Misses             20963    20936      -27     
- Partials            2603     2636      +33     
Flag Coverage Δ
e2e 55.46% <100.00%> (-0.01%) ⬇️
unit 72.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jun 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 18, 2024
@kodiakhq kodiakhq bot merged commit 0d5ce1a into release-6.9.2 Jun 18, 2024
@kodiakhq kodiakhq bot deleted the backport-6.9.2-32547 branch June 18, 2024 16:58
ggazzo pushed a commit that referenced this pull request Jun 18, 2024
…on policy enabled (#32622)

Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant