fix: Enable encryption for direct/private rooms by default is overriding E2EE setting#32624
Merged
kodiakhq[bot] merged 5 commits intodevelopfrom Jun 19, 2024
Merged
fix: Enable encryption for direct/private rooms by default is overriding E2EE setting#32624kodiakhq[bot] merged 5 commits intodevelopfrom
kodiakhq[bot] merged 5 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 3cc5f0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32624 +/- ##
===========================================
- Coverage 56.54% 55.96% -0.59%
===========================================
Files 2484 2421 -63
Lines 54743 53600 -1143
Branches 11305 11036 -269
===========================================
- Hits 30955 29997 -958
+ Misses 21106 20979 -127
+ Partials 2682 2624 -58
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
approved these changes
Jun 19, 2024
tassoevan
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
We have a setting to force creation of new private groups as encrypted rooms. This setting was being applied even when the entire e2ee feature was disabled. We should not apply this setting when the feature is not enabled. So checking if the E2EE feature is enabled before applying this setting
Issue(s)
Steps to test or reproduce
Further comments
E2EE2-29