Skip to content

fix: Settings code mirror broken on full screen mode#32625

Merged
kodiakhq[bot] merged 5 commits intodevelopfrom
fix/codeMirror-fullscreen
Jun 19, 2024
Merged

fix: Settings code mirror broken on full screen mode#32625
kodiakhq[bot] merged 5 commits intodevelopfrom
fix/codeMirror-fullscreen

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Jun 18, 2024

Introduced here: #31843

Proposed changes (including videos or screenshots)

before

after

Issue(s)

Steps to test or reproduce

Further comments

SUP-606

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 3d12129

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 6.10 milestone Jun 18, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.07%. Comparing base (70e3968) to head (3d12129).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32625   +/-   ##
========================================
  Coverage    55.06%   55.07%           
========================================
  Files         2397     2397           
  Lines        53207    53210    +3     
  Branches     10946    10947    +1     
========================================
+ Hits         29301    29305    +4     
- Misses       21318    21320    +2     
+ Partials      2588     2585    -3     
Flag Coverage Δ
e2e 53.37% <80.00%> (-0.01%) ⬇️
unit 72.16% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the title fix: Setting's code mirror broken on full screen mode fix: Settings code mirror broken on full screen mode Jun 19, 2024
@dougfabris dougfabris marked this pull request as ready for review June 19, 2024 13:58
@dougfabris dougfabris requested a review from a team as a code owner June 19, 2024 13:59
tassoevan
tassoevan previously approved these changes Jun 19, 2024
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jun 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
@dougfabris dougfabris removed the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
@dougfabris dougfabris requested a review from tassoevan June 19, 2024 15:45
@kodiakhq kodiakhq bot merged commit c5edd04 into develop Jun 19, 2024
@kodiakhq kodiakhq bot deleted the fix/codeMirror-fullscreen branch June 19, 2024 17:49
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants