Skip to content

fix(Livechat): Restore missing setDepartment livechat API endpoint functionality #32626

Merged
ggazzo merged 16 commits intodevelopfrom
setDepartment-fixes
Jun 26, 2024
Merged

fix(Livechat): Restore missing setDepartment livechat API endpoint functionality #32626
ggazzo merged 16 commits intodevelopfrom
setDepartment-fixes

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Jun 18, 2024

CORE-512
CORE-511

This PR fixes some behaviours that went missing on the setDepartment livechat api method:

  • Changing the department didn't reflect on the registration form in real time
  • Changing the department mid conversation didn't transfer the chat
  • Depending on the state of the department, it couldn't be set as default

@MartinSchoeler MartinSchoeler added this to the 6.8 milestone Jun 18, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: bea6d72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/livechat Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.69%. Comparing base (209a062) to head (bea6d72).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32626      +/-   ##
===========================================
- Coverage    56.76%   56.69%   -0.08%     
===========================================
  Files         2496     2498       +2     
  Lines        55358    55390      +32     
  Branches     11455    11457       +2     
===========================================
- Hits         31423    31401      -22     
- Misses       21241    21283      +42     
- Partials      2694     2706      +12     
Flag Coverage Δ
e2e 56.44% <ø> (-0.08%) ⬇️
e2e-api 41.32% <ø> (-0.04%) ⬇️
unit 71.86% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler removed this from the 6.8 milestone Jun 19, 2024
@MartinSchoeler MartinSchoeler changed the base branch from release-6.8.1 to develop June 19, 2024 11:48
@MartinSchoeler MartinSchoeler added this to the 6.10 milestone Jun 19, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 21, 2024 12:38
@MartinSchoeler MartinSchoeler requested review from a team as code owners June 21, 2024 12:38
@MartinSchoeler MartinSchoeler modified the milestones: 6.10, 6.8 Jun 21, 2024
Copy link
Copy Markdown
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we have a better explained title?

@MartinSchoeler MartinSchoeler changed the title fix(Livechat): setDepartment fixes fix(Livechat): Restore missing setDepartment livechat API endpoint functionality Jun 21, 2024
@MartinSchoeler MartinSchoeler marked this pull request as draft June 25, 2024 16:09
@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 25, 2024 16:34
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jun 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 25, 2024
@ggazzo ggazzo merged commit dbc79b7 into develop Jun 26, 2024
@ggazzo ggazzo deleted the setDepartment-fixes branch June 26, 2024 21:46
@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Jun 27, 2024

/patch

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 27, 2024

Pull request #32683 added to Project: "undefined"

@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Jun 27, 2024

/backport 6.8.3

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 27, 2024

Pull request #32684 added to Project: "undefined"

@MartinSchoeler MartinSchoeler modified the milestones: 6.10, 6.11 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants