fix: Modal backdrop overlapping Select options#32640
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 984faff The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32640 +/- ##
===========================================
- Coverage 56.56% 56.53% -0.03%
===========================================
Files 2484 2484
Lines 54755 54755
Branches 11308 11308
===========================================
- Hits 30971 30955 -16
- Misses 21107 21120 +13
- Partials 2677 2680 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
previously approved these changes
Jun 19, 2024
ggazzo
reviewed
Jun 21, 2024
ggazzo
reviewed
Jun 21, 2024
ggazzo
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Introduced here: #32067
In order to solve an issue where the
UserCardwas overlapping the Modal as shown in the PR above we changed thez-indexofModalBackdropand it caused theModalBackdropoverlapping theSelectoptions.So to solve it, we come back with the old
z-indexvalue and added a callbackAction to close theUserCardas soon as the action is triggered.before
after
Issue(s)
Steps to test or reproduce
Further comments
CORE-522