Skip to content

Comments

regression: Incorrect translation of room data on listeners of message events#32641

Merged
ggazzo merged 3 commits intodevelopfrom
regression/apps-message-listeners
Jun 21, 2024
Merged

regression: Incorrect translation of room data on listeners of message events#32641
ggazzo merged 3 commits intodevelopfrom
regression/apps-message-listeners

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jun 20, 2024

Proposed changes (including videos or screenshots)

Implementation reference RocketChat/Rocket.Chat.Apps-engine#769

Issue(s)

Steps to test or reproduce

The problem happens with apps that use the message events and tried to read the usernames from the message room via message.room.usernames. To test it, you can deploy any app that implements a message event (e.g. IPostMessageSent) and uses that same API

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 20, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: d32c23c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert added this to the 6.10 milestone Jun 20, 2024
@codecov
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.55%. Comparing base (1428778) to head (d32c23c).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32641      +/-   ##
===========================================
- Coverage    56.56%   56.55%   -0.01%     
===========================================
  Files         2484     2484              
  Lines        54755    54755              
  Branches     11308    11308              
===========================================
- Hits         30971    30966       -5     
- Misses       21107    21113       +6     
+ Partials      2677     2676       -1     
Flag Coverage Δ
e2e 56.19% <ø> (-0.06%) ⬇️
unit 72.22% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jun 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2024
@ggazzo ggazzo merged commit 68b624e into develop Jun 21, 2024
@ggazzo ggazzo deleted the regression/apps-message-listeners branch June 21, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants