refactor(tests): API tests

[tassoevan]

Proposed changes (including videos or screenshots)

It migrates integration tests to TypeScript.

Issue(s)

Steps to test or reproduce

Further comments

The goal of this changes is to raise the maintenance rate and, subsequently, the quality of these tests.

Before

🟠 JavaScript files: 333
🔵 TypeScript files: 6465
      🧪 Conversion: 95.10%

🟠 JavaScript LOCs: 55515
🔵 TypeScript LOCs: 409232
      🧪 Conversion: 88.05%

  JavaScript biggest files:
    apps/meteor/tests/end-to-end/api/01-users.js (125.04kb)
    apps/meteor/server/models/raw/Users.js (56.83kb)
    apps/meteor/app/slackbridge/server/SlackAdapter.js (43.78kb)
    apps/meteor/app/markdown/lib/hljs.js (19.49kb)
    packages/node-poplib/src/index.js (18.83kb)
    packages/eslint-config/style/index.js (15.81kb)
    packages/eslint-config/imports/index.js (10.80kb)
    packages/eslint-config/best-practices/index.js (9.15kb)
    apps/meteor/public/enc.js (2.99kb)
    packages/message-parser/webpack.config.js (1.79kb)

After

🟠 JavaScript files: 292
🔵 TypeScript files: 6500
      🧪 Conversion: 95.70%

🟠 JavaScript LOCs: 30317
🔵 TypeScript LOCs: 434714
      🧪 Conversion: 93.48%

  JavaScript biggest files:
    apps/meteor/server/models/raw/Users.js (56.83kb)
    apps/meteor/app/slackbridge/server/SlackAdapter.js (43.78kb)
    apps/meteor/app/markdown/lib/hljs.js (19.49kb)
    packages/node-poplib/src/index.js (18.83kb)
    packages/eslint-config/style/index.js (15.81kb)
    packages/eslint-config/imports/index.js (10.80kb)
    packages/eslint-config/best-practices/index.js (9.15kb)
    apps/meteor/public/enc.js (2.99kb)
    packages/message-parser/webpack.config.js (1.79kb)
    packages/eslint-config/react.js (0.97kb)

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 191e534

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (1827e95) to head (b654f09).
Report is 3 commits behind head on develop.

❗ Current head b654f09 differs from pull request most recent head 191e534

Please upload reports for the commit 191e534 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32643      +/-   ##
===========================================
- Coverage    56.73%   56.72%   -0.01%     
===========================================
  Files         2496     2496              
  Lines        55360    55359       -1     
  Branches     11455    11455              
===========================================
- Hits         31407    31403       -4     
+ Misses       21255    21253       -2     
- Partials      2698     2703       +5     

Flag	Coverage Δ
e2e	56.47% <ø> (-0.01%)	⬇️
unit	71.85% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sampaiodiego]

are these changes because of our eslint rules? just want to point this out https://mochajs.org/#arrow-functions

I wonder if should have a mix of arrow and non-arrow functions when the this context is needed, or if we should stick to one or the other

[tassoevan]

ESLint rules. However, @typescript-eslint ensures functions are converted to arrow functions only when there is no references to this.
Personally, it feels like there is very little situations where we need to use the Mocha context e.g. this.retries(n) was redudant with the current configuration and calls to this.skip() are rare and easily replaced with it.skip/describe.skip.

[sampaiodiego]

do you have a before/after of JS/TS files? I'm just curious about the new stats