Skip to content

test: Rewrite getByRole buttons to match exact string#32652

Merged
ggazzo merged 1 commit intodevelopfrom
tests/page-object-selectors
Jun 22, 2024
Merged

test: Rewrite getByRole buttons to match exact string#32652
ggazzo merged 1 commit intodevelopfrom
tests/page-object-selectors

Conversation

@juliajforesti
Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 21, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: 4e75656

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliajforesti juliajforesti changed the title tests: rewrite getByRole buttons to match exact string test: rewrite getByRole buttons to match exact string Jun 21, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.53%. Comparing base (6274c43) to head (4e75656).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32652      +/-   ##
===========================================
- Coverage    56.54%   56.53%   -0.02%     
===========================================
  Files         2490     2490              
  Lines        55028    55028              
  Branches     11385    11385              
===========================================
- Hits         31114    31108       -6     
- Misses       21231    21235       +4     
- Partials      2683     2685       +2     
Flag Coverage Δ
e2e 56.18% <ø> (-0.03%) ⬇️
unit 71.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title test: rewrite getByRole buttons to match exact string test:Rewrite getByRole buttons to match exact string Jun 22, 2024
@ggazzo ggazzo changed the title test:Rewrite getByRole buttons to match exact string test: Rewrite getByRole buttons to match exact string Jun 22, 2024
@ggazzo ggazzo marked this pull request as ready for review June 22, 2024 00:53
@ggazzo ggazzo requested a review from a team as a code owner June 22, 2024 00:53
@ggazzo ggazzo merged commit 865a5aa into develop Jun 22, 2024
@ggazzo ggazzo deleted the tests/page-object-selectors branch June 22, 2024 00:54
@ggazzo ggazzo added this to the 6.10 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants