Skip to content

i18n: change text on enable message history setting description#32662

Merged
kodiakhq[bot] merged 9 commits intodevelopfrom
chore/SUP-604-change-text
Jul 9, 2024
Merged

i18n: change text on enable message history setting description#32662
kodiakhq[bot] merged 9 commits intodevelopfrom
chore/SUP-604-change-text

Conversation

@csuadev
Copy link
Copy Markdown
Contributor

@csuadev csuadev commented Jun 24, 2024

Change text on Enable Message History description since it was telling the user that this setting enables the endpoint /api/v1/im.history.others and its /api/v1/im.messages.others.

Proposed changes (including videos or screenshots)

image

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-604

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: 37792f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (7cf2dae) to head (37792f7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32662      +/-   ##
===========================================
- Coverage    56.86%   56.86%   -0.01%     
===========================================
  Files         2498     2497       -1     
  Lines        55346    55315      -31     
  Branches     11416    11410       -6     
===========================================
- Hits         31474    31454      -20     
+ Misses       21188    21149      -39     
- Partials      2684     2712      +28     
Flag Coverage Δ
e2e 56.51% <ø> (-0.01%) ⬇️
unit 72.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuadev csuadev marked this pull request as ready for review June 24, 2024 16:54
Copy link
Copy Markdown
Contributor

@matheusbsilva137 matheusbsilva137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we delete the translations in all other languages so that they are re-generated?
btw I believe we should mark this PR as i18n instead of chore 🤔

@csuadev csuadev marked this pull request as draft June 24, 2024 17:03
@csuadev csuadev changed the title chore: change text on enable message history setting description i18n: change text on enable message history setting description Jun 24, 2024
@csuadev csuadev requested a review from matheusbsilva137 June 24, 2024 18:35
@csuadev csuadev marked this pull request as ready for review June 24, 2024 18:35
@matheusbsilva137 matheusbsilva137 added this to the 6.11 milestone Jun 25, 2024
@csuadev csuadev requested a review from MarcosSpessatto June 26, 2024 15:05
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jun 28, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2024
@kodiakhq kodiakhq bot merged commit 3db043f into develop Jul 9, 2024
@kodiakhq kodiakhq bot deleted the chore/SUP-604-change-text branch July 9, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants