Skip to content

test: improve selectors specificity#32665

Merged
ggazzo merged 5 commits intodevelopfrom
test/selectors-specificity
Jun 24, 2024
Merged

test: improve selectors specificity#32665
ggazzo merged 5 commits intodevelopfrom
test/selectors-specificity

Conversation

@juliajforesti
Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: 1428d3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.71%. Comparing base (c02d451) to head (1428d3e).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32665      +/-   ##
===========================================
+ Coverage    56.69%   56.71%   +0.01%     
===========================================
  Files         2489     2496       +7     
  Lines        55276    55359      +83     
  Branches     11441    11457      +16     
===========================================
+ Hits         31340    31397      +57     
- Misses       21237    21257      +20     
- Partials      2699     2705       +6     
Flag Coverage Δ
e2e 56.44% <100.00%> (+0.03%) ⬆️
unit 71.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review June 24, 2024 22:21
@ggazzo ggazzo requested a review from a team as a code owner June 24, 2024 22:21
@ggazzo ggazzo added this to the 6.11 milestone Jun 24, 2024
@ggazzo ggazzo merged commit 209a062 into develop Jun 24, 2024
@ggazzo ggazzo deleted the test/selectors-specificity branch June 24, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants