Skip to content

chore: fix uikit PreviewBlock typings #32676

Merged
ggazzo merged 1 commit intodevelopfrom
chore/fix-typings
Jun 25, 2024
Merged

chore: fix uikit PreviewBlock typings #32676
ggazzo merged 1 commit intodevelopfrom
chore/fix-typings

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jun 25, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 4611809

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.74%. Comparing base (2597791) to head (4611809).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32676      +/-   ##
===========================================
+ Coverage    56.71%   56.74%   +0.02%     
===========================================
  Files         2496     2495       -1     
  Lines        55360    55327      -33     
  Branches     11455    11451       -4     
===========================================
- Hits         31400    31397       -3     
+ Misses       21263    21232      -31     
- Partials      2697     2698       +1     
Flag Coverage Δ
e2e 56.50% <ø> (+0.04%) ⬆️
unit 71.88% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title chore: fix apps engine typings chore: fix uikit PreviewBlock typings Jun 25, 2024
@ggazzo ggazzo marked this pull request as ready for review June 25, 2024 23:52
@ggazzo ggazzo merged commit c3489db into develop Jun 25, 2024
@ggazzo ggazzo deleted the chore/fix-typings branch June 25, 2024 23:54
@ggazzo ggazzo added this to the 6.11 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants