Skip to content

refactor(ui-kit): Add tests for types#32678

Merged
kodiakhq[bot] merged 5 commits intodevelopfrom
refactor/ui-kit-type-assertions
Jul 8, 2024
Merged

refactor(ui-kit): Add tests for types#32678
kodiakhq[bot] merged 5 commits intodevelopfrom
refactor/ui-kit-type-assertions

Conversation

@tassoevan
Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

UIKit types are not open for extension, therefore we can't use interface declarations nor enjoy the advantage of the extends construct for them. This pull request add types for assert type shapes in compilation type.

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: 6c86749

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.73%. Comparing base (b7deefa) to head (6c86749).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32678   +/-   ##
========================================
  Coverage    56.72%   56.73%           
========================================
  Files         2494     2498    +4     
  Lines        55343    55392   +49     
  Branches     11448    11455    +7     
========================================
+ Hits         31396    31425   +29     
- Misses       21247    21267   +20     
  Partials      2700     2700           
Flag Coverage Δ
e2e 56.49% <ø> (+<0.01%) ⬆️
unit 71.93% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/ui-kit-type-assertions branch from 1221caa to 33c28c2 Compare June 27, 2024 03:45
@tassoevan tassoevan marked this pull request as ready for review June 27, 2024 10:02
@tassoevan tassoevan requested a review from a team June 27, 2024 10:02
@tassoevan tassoevan added this to the 6.11 milestone Jul 2, 2024
Copy link
Copy Markdown
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 2, 2024
@kodiakhq kodiakhq bot merged commit 996933b into develop Jul 8, 2024
@kodiakhq kodiakhq bot deleted the refactor/ui-kit-type-assertions branch July 8, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants