fix(UiKit): Modal validation not working#32679
Merged
kodiakhq[bot] merged 9 commits intodevelopfrom Jul 22, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f454ae9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32679 +/- ##
===========================================
- Coverage 55.58% 55.55% -0.03%
===========================================
Files 2635 2635
Lines 57289 57289
Branches 11864 11864
===========================================
- Hits 31843 31828 -15
- Misses 22750 22764 +14
- Partials 2696 2697 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
Jun 27, 2024
Contributor
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we add tests to ensure it?
…cket.Chat into fix/validation-error-uikit
MarcosSpessatto
previously approved these changes
Jul 5, 2024
…validation-error-uikit
MarcosSpessatto
previously approved these changes
Jul 17, 2024
MartinSchoeler
requested changes
Jul 19, 2024
5a0f0a7 to
430fce9
Compare
430fce9 to
362b9cf
Compare
MartinSchoeler
approved these changes
Jul 19, 2024
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Bring back modal validations response to inputs:
Issue(s)
Steps to test or reproduce
Further comments
CORE-469