Skip to content

test: close pages properly#32681

Merged
ggazzo merged 2 commits intodevelopfrom
test/close-page
Jun 27, 2024
Merged

test: close pages properly#32681
ggazzo merged 2 commits intodevelopfrom
test/close-page

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jun 26, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: 43f77e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.71%. Comparing base (dbc79b7) to head (43f77e0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32681      +/-   ##
===========================================
+ Coverage    56.69%   56.71%   +0.02%     
===========================================
  Files         2498     2497       -1     
  Lines        55390    55359      -31     
  Branches     11457    11451       -6     
===========================================
- Hits         31403    31398       -5     
+ Misses       21282    21257      -25     
+ Partials      2705     2704       -1     
Flag Coverage Δ
e2e 56.49% <ø> (+0.04%) ⬆️
unit 71.86% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review June 27, 2024 09:14
@ggazzo ggazzo requested a review from a team as a code owner June 27, 2024 09:14
@ggazzo ggazzo added this to the 6.11 milestone Jun 27, 2024
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jun 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 27, 2024
@ggazzo ggazzo merged commit b5866a1 into develop Jun 27, 2024
@ggazzo ggazzo deleted the test/close-page branch June 27, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants