Skip to content

test: Rename api test files removing order (except livechat)#32689

Merged
ggazzo merged 14 commits intodevelopfrom
test/rename-api-files-2
Jul 8, 2024
Merged

test: Rename api test files removing order (except livechat)#32689
ggazzo merged 14 commits intodevelopfrom
test/rename-api-files-2

Conversation

@MarcosSpessatto
Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

https://rocketchat.atlassian.net/browse/CORE-476

This PR renames the API files (except Livechat) removing the order of the files.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 27, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: 14ecd84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (b0f182e) to head (14ecd84).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32689      +/-   ##
===========================================
+ Coverage    56.82%   56.83%   +0.01%     
===========================================
  Files         2495     2498       +3     
  Lines        55295    55335      +40     
  Branches     11402    11411       +9     
===========================================
+ Hits         31421    31451      +30     
- Misses       21173    21179       +6     
- Partials      2701     2705       +4     
Flag Coverage Δ
e2e 56.46% <ø> (-0.01%) ⬇️
unit 72.55% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review June 27, 2024 19:54
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner June 27, 2024 19:54
@MarcosSpessatto MarcosSpessatto changed the title test: Rename api test files removing order test: Rename api test files removing order (except livechat) Jun 27, 2024
sampaiodiego
sampaiodiego previously approved these changes Jun 27, 2024
@scuciatto scuciatto added this to the 6.11 milestone Jul 3, 2024
Base automatically changed from test/fix-last-dependent-cases to develop July 8, 2024 16:02
@kodiakhq kodiakhq bot dismissed sampaiodiego’s stale review July 8, 2024 16:02

The base branch was changed.

@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Jul 8, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 8, 2024
@ggazzo ggazzo merged commit ca3d90b into develop Jul 8, 2024
@ggazzo ggazzo deleted the test/rename-api-files-2 branch July 8, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants