Skip to content

fix(livechat): make trigger use correct dep on agent.next#32692

Merged
kodiakhq[bot] merged 12 commits intodevelopfrom
department-trigger-relation
Jul 22, 2024
Merged

fix(livechat): make trigger use correct dep on agent.next#32692
kodiakhq[bot] merged 12 commits intodevelopfrom
department-trigger-relation

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Jun 27, 2024

CORE-526

Fixes an issue that caused the request for agent.next on the widget to call the wrong department when using the setDepartment api endpoint in conjunction with a Livechat Trigger

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: a48a14b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/livechat Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jun 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@MartinSchoeler MartinSchoeler added this to the 6.11 milestone Jun 27, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55%. Comparing base (5bfde8d) to head (a48a14b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32692      +/-   ##
===========================================
- Coverage    55.62%   55.55%   -0.08%     
===========================================
  Files         2637     2637              
  Lines        57308    57308              
  Branches     11868    11868              
===========================================
- Hits         31880    31839      -41     
- Misses       22741    22779      +38     
- Partials      2687     2690       +3     
Flag Coverage Δ
e2e 54.20% <ø> (-0.14%) ⬇️
unit 72.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 27, 2024 21:31
@MartinSchoeler MartinSchoeler requested review from a team as code owners June 27, 2024 21:31
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2024
@scuciatto scuciatto added the stat: ready to merge PR tested and approved waiting for merge label Jul 20, 2024
@kodiakhq kodiakhq bot merged commit 580c1ed into develop Jul 22, 2024
@kodiakhq kodiakhq bot deleted the department-trigger-relation branch July 22, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants