fix: settings disappear on UI navigation back and forth

[abhinavkrin]

Proposed changes (including videos or screenshots)

This PR addresses an issue where the "Hide System Messages" setting disappears after navigating back and forth in the Rocket.Chat UI. The problem was observed under network latency conditions when the realtime update of the setting is received much before the resolution of the saveSettings method call.
The upsert function under the PrivateSettingsCachedCollection replaced the original doc with the received fields, instead of merging with the original doc. This made the setting doc lose its shape and hence failed the isSetting
test in the UI components.

Before

before-hide-system-messages.mp4

After

after-hide-system-messages.mp4

Issue(s)

Steps to test or reproduce

1. Navigate to the Message Settings Page: Open Chrome and go to https://your-rocketchat-domain/admin/settings/Message.
2. Set Network Speed to Slow 3G: Open Chrome DevTools (F12 or right-click and select "Inspect"). Go to the Network tab. Select Slow 3G from the throttling options.
3. Change a Setting: Locate the Hide System Messages setting. Click on the input field and enter User joined, then press Enter.
4. Save the Changes: Click the Save changes button.
5. Navigate Back and Forth: Quickly click the Back button before the "Settings saved" popup appears or wait for the "Settings saved" popup to appear, then navigate back.
6. Navigate to Message Settings Again: Click on Message again to navigate back to the message settings page.
7. Verify the Setting: Check if the Hide System Messages option appears on the screen.

Further comments

SUP-571

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 14e96c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.43%. Comparing base (4ba8c04) to head (14e96c6).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32713      +/-   ##
===========================================
- Coverage    55.54%   54.43%   -1.12%     
===========================================
  Files         2634     2554      -80     
  Lines        57215    56026    -1189     
  Branches     11849    11622     -227     
===========================================
- Hits         31781    30495    -1286     
- Misses       22742    22924     +182     
+ Partials      2692     2607      -85     

Flag	Coverage Δ
e2e	52.04% <100.00%> (-2.28%)	⬇️
unit	72.17% <ø> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

Can we add a changeset?