refactor: create middleware to handle dbWatchersDisabled check#32721
refactor: create middleware to handle dbWatchersDisabled check#32721kodiakhq[bot] merged 4 commits intodevelopfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32721 +/- ##
===========================================
+ Coverage 50.60% 56.81% +6.21%
===========================================
Files 1950 2498 +548
Lines 46689 55335 +8646
Branches 9489 11411 +1922
===========================================
+ Hits 23627 31441 +7814
- Misses 20933 21187 +254
- Partials 2129 2707 +578
Flags with carried forward coverage won't be shown. Click here to find out more. |
810efe7 to
6861c00
Compare
KevLehman
left a comment
There was a problem hiding this comment.
Liked a bit more the 1st approach 😢
But this looks nice as well!
This refactor introduces a middleware function,
withDbWatcherCheck, to handle thedbWatchersDisabledcheck uniformly across various notification functions. By applying this middleware, we ensure that the flag checks are consistently managed, reducing redundancy and potential errors.The primary changes involve:
withDbWatcherCheckmiddleware to wrap notification functions.withDbWatcherCheckwrapper applied.