fix: sendFCM function not using @rocket.chat/server-fetch#32739
Merged
kodiakhq[bot] merged 8 commits intodevelopfrom Jul 9, 2024
Merged
fix: sendFCM function not using @rocket.chat/server-fetch#32739kodiakhq[bot] merged 8 commits intodevelopfrom
sendFCM function not using @rocket.chat/server-fetch#32739kodiakhq[bot] merged 8 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 2304a31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sendFCM function not using @rocket.chat/serverFetchsendFCM function not using @rocket.chat/server-fetch
Gustrb
previously approved these changes
Jul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32739 +/- ##
===========================================
+ Coverage 50.82% 56.84% +6.02%
===========================================
Files 1933 2498 +565
Lines 46542 55346 +8804
Branches 9419 11416 +1997
===========================================
+ Hits 23654 31461 +7807
- Misses 20755 21171 +416
- Partials 2133 2714 +581
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
reviewed
Jul 8, 2024
KevLehman
previously approved these changes
Jul 8, 2024
Gustrb
reviewed
Jul 8, 2024
Gustrb
approved these changes
Jul 8, 2024
pierre-lehnen-rc
approved these changes
Jul 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use legacy notification provider setting is disabled in Workspace > Settings > Push, push notifications stop going to Android devices. PR Should fix this situation for using a proxy for it
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-616
Steps to test or reproduce
Further comments