Skip to content

ci: force Tests Done to fail if needs fails#32750

Merged
ggazzo merged 2 commits intodevelopfrom
ci/help-kodiak
Jul 9, 2024
Merged

ci: force Tests Done to fail if needs fails#32750
ggazzo merged 2 commits intodevelopfrom
ci/help-kodiak

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jul 9, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 9, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 9, 2024

⚠️ No Changeset found

Latest commit: 2075a43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (7cf2dae) to head (2075a43).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32750      +/-   ##
===========================================
- Coverage    56.86%   56.83%   -0.04%     
===========================================
  Files         2498     2498              
  Lines        55346    55346              
  Branches     11416    11416              
===========================================
- Hits         31474    31457      -17     
- Misses       21167    21175       +8     
- Partials      2705     2714       +9     
Flag Coverage Δ
e2e 56.47% <ø> (-0.06%) ⬇️
unit 72.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review July 9, 2024 21:14
@ggazzo ggazzo requested a review from a team as a code owner July 9, 2024 21:14
@ggazzo ggazzo changed the title ci: force Tests Done to fail if needs fails ci: force Tests Done to fail if needs fails Jul 9, 2024
@ggazzo ggazzo merged commit 6d689bd into develop Jul 9, 2024
@ggazzo ggazzo deleted the ci/help-kodiak branch July 9, 2024 22:27
@ggazzo ggazzo added this to the 6.11 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants