Skip to content

refactor(omnichannel): remove getRoom helper#32751

Merged
ggazzo merged 7 commits intodevelopfrom
refator/queuemanager
Jul 10, 2024
Merged

refactor(omnichannel): remove getRoom helper#32751
ggazzo merged 7 commits intodevelopfrom
refator/queuemanager

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jul 10, 2024

OPI-14

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: 8479cc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the refator/queuemanager branch from 96a83be to 470f0e1 Compare July 10, 2024 03:08
@ggazzo ggazzo changed the title refactor(omnichannel): WIP refactor(omnichannel): remove getRoom helper Jul 10, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.79%. Comparing base (9a54063) to head (8479cc9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32751   +/-   ##
========================================
  Coverage    56.78%   56.79%           
========================================
  Files         2501     2504    +3     
  Lines        55488    55528   +40     
  Branches     11434    11443    +9     
========================================
+ Hits         31511    31538   +27     
- Misses       21271    21272    +1     
- Partials      2706     2718   +12     
Flag Coverage Δ
e2e 56.46% <ø> (+0.02%) ⬆️
unit 72.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the refator/queuemanager branch from 470f0e1 to a9c50a6 Compare July 10, 2024 03:24
@ggazzo ggazzo marked this pull request as ready for review July 10, 2024 20:44
@ggazzo ggazzo requested review from a team as code owners July 10, 2024 20:44
@ggazzo ggazzo added this to the 6.11 milestone Jul 10, 2024
@ggazzo ggazzo merged commit 35301a4 into develop Jul 10, 2024
@ggazzo ggazzo deleted the refator/queuemanager branch July 10, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants