Skip to content

fix: AAC audio type does not play on web#32764

Closed
matheusbsilva137 wants to merge 1 commit intodevelopfrom
fix/aac-not-playing-incorrect-mime
Closed

fix: AAC audio type does not play on web#32764
matheusbsilva137 wants to merge 1 commit intodevelopfrom
fix/aac-not-playing-incorrect-mime

Conversation

@matheusbsilva137
Copy link
Copy Markdown
Contributor

@matheusbsilva137 matheusbsilva137 commented Jul 11, 2024

Proposed changes (including videos or screenshots)

  • Define aac files MIME type as audio/aac instead of audio/x-aac (which is not supported by our audio player);

Issue(s)

Introduced by #32471

Steps to test or reproduce

Further comments

NATIVE-592

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 11, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: a90069f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.66%. Comparing base (f2cb691) to head (a90069f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32764   +/-   ##
========================================
  Coverage    56.65%   56.66%           
========================================
  Files         2504     2504           
  Lines        55524    55525    +1     
  Branches     11442    11442           
========================================
+ Hits         31456    31461    +5     
+ Misses       21380    21376    -4     
  Partials      2688     2688           
Flag Coverage Δ
e2e 56.47% <100.00%> (+0.02%) ⬆️
unit 72.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137
Copy link
Copy Markdown
Contributor Author

Closing in favor of #32763 (the changes suggested in this PR have been incorporated there)

@tassoevan tassoevan deleted the fix/aac-not-playing-incorrect-mime branch July 30, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant