fix: option to start a discussion on an existing message is not showing up#32765
Merged
kodiakhq[bot] merged 11 commits intodevelopfrom Jul 22, 2024
Merged
fix: option to start a discussion on an existing message is not showing up#32765kodiakhq[bot] merged 11 commits intodevelopfrom
kodiakhq[bot] merged 11 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b500826 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32765 +/- ##
===========================================
+ Coverage 55.53% 55.60% +0.07%
===========================================
Files 2633 2637 +4
Lines 57259 57308 +49
Branches 11861 11868 +7
===========================================
+ Hits 31796 31865 +69
+ Misses 22773 22752 -21
- Partials 2690 2691 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
approved these changes
Jul 12, 2024
gabriellsh
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
…ng up (#32765) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition to show the "Start a Discussion" option on the message Actions list was accidentally changed as a side effect of an older PR.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
PR #23971 changed a reference to the global
isNaNwithNumber.isNaN. The two functions are not interchangeable, despite having the same name.The global
isNaNwill check if something is not a number, whileNumber.isNaNchecks if the specified value is specifically NaN.In the condition for the discussion action, an undefined
dcountwould causeNumber.isNaNto return false and rocket.chat would then hide the option thinking that it is already a discussion.