fix: Reload page after redirect flow ends to avoid reactivity issues

[KevLehman]

https://rocketchat.atlassian.net/browse/SUP-619

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

PR adds an additional step to the redirect flow of OAuth logins, refreshing the page to recover reactivity on the UI.

This should fix most user inconsistencies happening after a login via OAuth (redirect). This shouldn't affect any other type of login, like, for example, popup flow.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4ae5f54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is targeting the wrong base branch. It should target 6.12.0, but it targets 6.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.58%. Comparing base (703af95) to head (4ae5f54).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32766      +/-   ##
===========================================
+ Coverage    55.56%   55.58%   +0.02%     
===========================================
  Files         2635     2635              
  Lines        57292    57309      +17     
  Branches     11865    11869       +4     
===========================================
+ Hits         31834    31856      +22     
+ Misses       22768    22757      -11     
- Partials      2690     2696       +6     

Flag	Coverage Δ
e2e	54.32% <52.94%> (+0.03%)	⬆️
unit	72.25% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

Is there any possibility of adding automated tests to cover this? Asking because I'm not sure if we can simulate that...

Also, can we add a description to the PR?

[KevLehman]

About testing, i don't think it's possible 😬 right now. I don't think we have any oauth login test 🤔and for reliability we would need an oauth server configured for the CI (like a keycloack server). Totally doable, but a project in itself

[ggazzo]

could you check if this #32929 solves the case?
I was not aware this was a real issue, I though only test were facing it

[KevLehman]

let me check

[KevLehman]

Closing this for now as apparently linked PR fixed the issue 🎉