fix: Sidebar scrolling misclick issue on iOS#32769
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 52b02c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MartinSchoeler
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32769 +/- ##
===========================================
- Coverage 55.50% 55.44% -0.07%
===========================================
Files 2637 2635 -2
Lines 57289 57270 -19
Branches 11859 11855 -4
===========================================
- Hits 31797 31752 -45
- Misses 22801 22828 +27
+ Partials 2691 2690 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
requested changes
Jul 11, 2024
Member
yash-rajpal
left a comment
yash-rajpal
left a comment
There was a problem hiding this comment.
LGTM other than the comment left.
yash-rajpal
previously approved these changes
Jul 12, 2024
Member
Author
|
Putting this as draft since the issue seems more complex than initially estimated |
MartinSchoeler
force-pushed
the
fix-ios-polyfill
branch
from
3df4802 to
c46866c
Compare
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
An outdated polyfill was causing misclick issues when scrolling the channels sidebar
Issue(s)
Steps to test or reproduce
Further comments
SUP-582