feat(Omnichannel): Attachments in Email Transcripts#32777
Merged
kodiakhq[bot] merged 12 commits intodevelopfrom Jul 19, 2024
Merged
feat(Omnichannel): Attachments in Email Transcripts#32777kodiakhq[bot] merged 12 commits intodevelopfrom
kodiakhq[bot] merged 12 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 620a3b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32777 +/- ##
===========================================
+ Coverage 55.51% 55.57% +0.05%
===========================================
Files 2634 2634
Lines 57248 57248
Branches 11853 11853
===========================================
+ Hits 31784 31813 +29
+ Misses 22769 22744 -25
+ Partials 2695 2691 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
previously requested changes
Jul 15, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Is there any way of adding some tests here?
tiagoevanp
reviewed
Jul 15, 2024
Contributor
tiagoevanp
left a comment
tiagoevanp
left a comment
There was a problem hiding this comment.
The description of PR is confusing, can you add a similar message from the changeset and show in the images who is before/after?
KevLehman
reviewed
Jul 15, 2024
KevLehman
reviewed
Jul 15, 2024
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
KevLehman
previously approved these changes
Jul 16, 2024
KevLehman
approved these changes
Jul 18, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
yash-rajpal
dismissed
MarcosSpessatto’s stale review
Discussed on DM, will implement tests for whole class separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
File attachments were not being handled in email transcripts, so implemented file attachments in email transcripts and invalid attachment message for attachments other than images.
Issue(s)
Steps to test or reproduce
Further comments
CORE-554